Adaption of scenario scripts for 1-node clusters
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- powershell
- Domain
- infrastructure
Research direction
Start by reviewing the scenario scripts for variables that hold cluster host names, then check the MSLab readme for the documented one-node guidance. Reproduce the reported invalid-hostname behavior with a one-node AZSHCI or WS2022 cluster and verify that the affected scenarios work with one hostname as well as multiple hostnames.
Written by the indexing model from the issue text.
Description
As Microsoft now supports 1-node clusters for AZSHCI and WS2022, I experimented a bit with the cluster scenario scripts for 1-node environments. I got various errors about non-existent host names.
Reason: Most scenario scripts initially define a variable for the names of the cluster nodes and implicitly assume that this results in a PowerShell array (e.g. $servers = "...", "..."). This works if you assign more than one hostname. However, if only 1 hostname is specified, PowerShell only creates a string variable - i.e. no array. If later the script references a single element (e.g. $server[0]), the result is an invalid hostname.
The remedy is simple: The variable for the host names should be set explicitly as an array type (e.g. [array] $servers="...").
However, this would mean that most of the scenario scripts would have to be adjusted and re-released. I would therefore suggest that an appropriate note be included in the MSLab readme page and the adjustments made in the scenario scripts when they are released as such.
- Dominant language
- PowerShell
- Stars
- 1.3k
- Forks
- 304
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from microsoft/MSLab
-
Difficulty 2/5 1-3 hours Newbie friendliness 30/100
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
Similar issues
-
kb-infra-drift
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
OCHA-DAP/ds-knowledge-base#653 · 1 comment ·
-
intake mcp-intake needs-ac needs-human-review priority:medium type:feature
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Ikalus1988/MisakaNet#2102 · 2 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
llvm/lighthouse#283 ·
-
🤔 refinement needed
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
equinor/radix-operator#1979 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100