Extend assembly loading warning to check for non-MSBuild but implicit dependencies like S.T.J and the SLNX library
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- csharp
- Domain
- build-system, devtools
Research direction
Start in src/MSBuildLocator/MSBuildLocator.cs around lines 340-362, where the ambiguous assembly-loading warning and checks are implemented. Review how the check handles dependencies already loaded by the MSBuild host, using System.Text.Json and Microsoft.VisualStudio.SolutionPersistence as the examples, and define completion as warning users about these implicit non-MSBuild dependencies when they attempt to load them incorrectly.
Written by the indexing model from the issue text.
Description
The warning/checks that tell users when there is ambiguous assembly loading is a great safety net, but it doesn't help users with dependencies that are implicitly provided by the MSbuild host - for example System.Text.Json and Microsoft.VisualStudio.SolutionPersistence. We should consider expanding our check here to see if we can help users understand when they are (incorrectly) attempting to load dependencies that the host has already loaded.
- Dominant language
- C#
- Stars
- 262
- Forks
- 91
- Avg merge
- 11d 22h
- Merged PRs (30d)
- 3
Getting set up
We have not checked this project's setup files yet. Start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from microsoft/MSBuildLocator
-
Difficulty 3/5 1-2 days Newbie friendliness 52/100
microsoft/MSBuildLocator#390 · 1 reaction ·
-
Difficulty 4/5 3-5 days Newbie friendliness 64/100
microsoft/MSBuildLocator#389 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
microsoft/MSBuildLocator#380 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
microsoft/MSBuildLocator#377 ·
-
Difficulty 5/5 Over a week Newbie friendliness 30/100
microsoft/MSBuildLocator#371 · 1 comment ·
All issues in microsoft/MSBuildLocator
Similar issues
-
area-System.Numerics.Tensors untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
dotnet/runtime#134691 · 2 comments ·
Maintainers usually reply within 1 day
-
ci-failure-cause test-failure
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
AvaloniaUI/Avalonia#22312 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 68/100