Updating locator from 1.4.1 to 1.5.3 breaks x86 processes

Open
#182 11 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp
Domain
build-system

Research direction

Start with the linked PR validation log and the failing tests BuildIntegrationLibGit2Tests.PublicRelease_RegEx_SatisfiedByCI and GetBuildVersion_CustomBuildNumberOffset. Read test/Nerdbank.GitVersioning.Tests/BuildIntegrationTests.cs around line 117, then compare behavior in x86 and x64 processes. Done means identifying and correcting the architecture mismatch, with the affected tests passing in both modes.

Written by the indexing model from the issue text.

Description

This simple upgrade PR updates Microsoft.Build.Locator from 1.4.1 to 1.5.3, the PR validation shows that the program now fails, exclusively when run in an x86 process. x64 is fine.

https://dev.azure.com/andrewarnott/OSS/_build/results?buildId=6997&view=logs&j=0bc77094-9fcd-5c38-f6e4-27d2ae131589&t=9d945b7d-bc5d-5e49-44ea-3bb51e12f2d5

[xUnit.net 00:00:25.18]     BuildIntegrationLibGit2Tests.PublicRelease_RegEx_SatisfiedByCI(serverProperties: [[APPVEYOR_REPO_TAG_NAME, ], [BUILD_SOURCEBRANCH, refs/heads/release], [APPVEYOR_PULL_REQUEST_NUMBER, ], [APPVEYOR_REPO_TAG, ], [APPVEYOR, ], ...]) [FAIL]
  Error Message:
   System.BadImageFormatException : An attempt was made to load a program with an incorrect format. (0x8007000B)
  Stack Trace:
     at BuildIntegrationTests.Init()
   at BuildIntegrationTests..ctor(ITestOutputHelper logger) in D:\a\1\s\test\Nerdbank.GitVersioning.Tests\BuildIntegrationTests.cs:line 117
   at BuildIntegrationLibGit2Tests..ctor(ITestOutputHelper logger) in D:\a\1\s\test\Nerdbank.GitVersioning.Tests\BuildIntegrationTests.cs:line 71
  Failed BuildIntegrationLibGit2Tests.GetBuildVersion_CustomBuildNumberOffset [1 ms]
  Error Message:
   System.BadImageFormatException : An attempt was made to load a program with an incorrect format. (0x8007000B)
  Stack Trace:
     at BuildIntegrationTests.Init()
   at BuildIntegrationTests..ctor(ITestOutputHelper logger) in D:\a\1\s\test\Nerdbank.GitVersioning.Tests\BuildIntegrationTests.cs:line 117

Is the Locator finding the x64 binaries when it should be finding x86 binaries?

Dominant language
C#
Stars
262
Forks
91
Avg merge
11d 22h
Merged PRs (30d)
3

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/MSBuildLocator

All issues in microsoft/MSBuildLocator

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.