microsoft/InnerEye-DeepLearning

Model baseline comparison shouldn't allow duplicates

Open

#506 opened on Jun 23, 2021

View on GitHub
 (0 comments) (0 reactions) (1 assignee)Python (519 stars) (138 forks)batch import
good first issuenot urgent

Description

The model config parameter comparison_blob_storage_paths takes a list of tuples, (name, container). The name is purely descriptive , and has no further meaning, but it is important that they are distinct otherwise multiple datasets from different containers may be merged in an unpredictable way. Essentially, it is better if this is a dict[name, container]. Add this validation to the validate function.

AB#4149

Contributor guide

Tech stack
pythonazure
Domain
backendmachine learning
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
PythonInnerEye DeepLearning project structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
The issue requests adding validation to the 'validate' function to ensure names in 'comparison blob storage paths' are unique. The change involves either converting the list of tuples to a dictionary or adding a duplicate check in the existing validation logic. Look for the configuration validation module in the repository, and note that there is an assignee, so coordinate with them before starting.