microsoft/GSL

Add performance tests to PR actions

Open

#1,167 opened on Nov 12, 2024

View on GitHub
 (7 comments) (0 reactions) (0 assignees)C++ (5,695 stars) (721 forks)batch import
Effort: MediumHelp WantedPriority: LowStatus: OpenType: Infra

Description

It is important to maintain performance parity to std::span (at the very least when Safe Buffers are enabled). In order to track this, we should have performance tests between std::span and gsl::span for the latest standard library implementation across Clang, GCC, and MSVC.

@galenelias put together small benchmark comparing the two implementations on various workloads. They have been attached for convenience and provide a good starting point.

span_bench.zip

Contributor guide

Tech stack
cpp
Domain
performancetesting
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C++performance testing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Implement performance benchmarks comparing gsl::span to std::span, using the attached span bench.zip as a starting point. The benchmarks should measure various workloads across Clang, GCC, and MSVC. Ensure the tests are integrated into the CI pipeline so that performance regression can be tracked automatically.