Missing await causes true evaluation
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 25/100
- Issue type
- Bug
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- javascript, typescript
- Domain
- api
Research direction
Start by locating the isEnabled implementation and any related usage or tests, then reproduce the conditional shown in the issue. The issue provides no target behavior beyond identifying the missing-await problem, so the intended resolution and completion criteria need clarification before implementation.
Written by the indexing model from the issue text.
Description
if (temp.isEnabled("foo")) {
button.className = "cool";
button.textContent = "Cool Button";
} else {
button.className = "lame";
button.textContent = "Lame Button";
}
We will always run the "cool" path here, because I didn't put an await on the isEnabled call. I think this is bad.
- Dominant language
- TypeScript
- Stars
- 19
- Forks
- 6
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 4
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from microsoft/FeatureManagement-JavaScript
-
Contributor Open
Difficulty 5/5 Over a week Newbie friendliness 15/100
microsoft/FeatureManagement-JavaScript#141 · 2 comments · 2 reactions ·
-
microsoft/FeatureManagement-JavaScript#89 · 1 comment · 1 assignee ·
-
microsoft/FeatureManagement-JavaScript#32 · 1 assignee ·
-
microsoft/FeatureManagement-JavaScript#31 · 1 assignee ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
microsoft/FeatureManagement-JavaScript#20 · 1 comment · 1 reaction ·
All issues in microsoft/FeatureManagement-JavaScript
Similar issues
-
clawsweeper:linked-pr-open clawsweeper:no-new-fix-pr clawsweeper:source-repro impact:message-loss issue-rating: 🦞 diamond lobster maturity:stable P2
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Eynzof/Hermes-CN-Desktop#616 ·
-
ZCode 3.14.3 に対応する Open
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
supermomonga/zcode-acp#24 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
growthbook/growthbook#7100 ·
-
triage
Difficulty 1/5 1-3 hours Newbie friendliness 88/100