Remove local D3D12_FEATURE_D3D12_OPTIONS_PREVIEW fallback once GroupSharedLimit ships in a released Windows SDK

Open Beginner friendly

#8,661 opened on Jul 23, 2026 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty: 2/5
Estimated time: 1-3 hours
Newbie friendliness: 74/100

Issue type: Refactor
Clarity: Mostly clear
Activity status: Quiet
Tech stack: cpp
Domain: compilers, testing

Research direction

Start with the TODOs in tools/clang/unittests/HLSLExec/HlslExecTestUtils.cpp, HlslExecTestUtils.h, and ExecutionTest.cpp, and inspect the local D3D12_FEATURE_D3D12_OPTIONS_PREVIEW fallback and related guards. Build against a released Windows SDK where GroupSharedLimit is available, then run the HLSLExec tests; done means the fallback and preview-only guards are removed while the tests and helpers compile and pass.

Written by the indexing model from the issue text.

Description

The HLSLExec GroupSharedLimit tests and their helpers rely on a local fallback definition of D3D12_FEATURE_D3D12_OPTIONS_PREVIEW (and its data struct), which is only available when building against a preview D3D SDK. The tests and helpers are therefore guarded with #if defined(D3D12_PREVIEW_SDK_VERSION) so they compile out on non-preview SDKs.

Once GroupSharedLimit / D3D12_FEATURE_D3D12_OPTIONS_PREVIEW is available in a released Windows SDK, the local fallback and these guards should be removed.

TODOs referencing this issue:

tools/clang/unittests/HLSLExec/HlslExecTestUtils.cpp
tools/clang/unittests/HLSLExec/HlslExecTestUtils.h
tools/clang/unittests/HLSLExec/ExecutionTest.cpp

Dominant language: C++
Stars: 3.7k
Forks: 900
Avg merge: 2d 14h
Merged PRs (30d): 39

Contributor guide

Open the contributing guide

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Similar issues

[Bug] NULL pointer dereference in llm_running_callback (NGZA-AX-LLM #3) Open

Difficulty 1/5 Under an hour Newbie friendliness 90/100

AXERA-TECH/ax-llm#77 · Opened Sep 22, 2026
pn7160: reader goes permanently deaf — post-read IRQ-low check fails reads that succeeded Open

Difficulty 2/5 1-3 hours Newbie friendliness 74/100

esphome/esphome#19452 · Opened Sep 21, 2026
Eval bug: Ministral-3 tool-calls during reasoning are not processed Open

bug-unconfirmed

Difficulty 2/5 1-3 hours Newbie friendliness 76/100

ggml-org/llama.cpp#29248 · Opened Sep 21, 2026
run_tests.py fails on windows, but running tests individually works Open

Difficulty 2/5 1-3 hours Newbie friendliness 74/100

NVIDIA/cuda-samples#453 · Opened Sep 21, 2026
Thrift import and export leak `AttributeError` for non-string delimiters Open

Difficulty 2/5 1-3 hours Newbie friendliness 78/100

infiniflow/infinity#3502 · Opened Sep 21, 2026

More C++ issues