Mismatch between Fig. 4 (Feature Extractor Module) of paper and implementaion
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 32/100
- Issue type
- Bug
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- python
- Domain
- computer-vision, machine-learning
Research direction
Start by comparing Fig. 4 of the paper with the feature extractor's forward method, including the forward_part1 and forward_part2 calls and the point where q_f is applied. Determine whether the implementation matches the diagram or whether the diagram needs clarification; done means the discrepancy is resolved and documented or corrected with supporting tests.
Written by the indexing model from the issue text.
Description
Hi and thanks for your great work
In figure 4 of the paper, we have this diagram for Feature Extractor module:
The second part (four DC block) takes $F_{t-1}^e$ as input right? but in the implementation:
def forward(self, x, quant):
x1, ctx_t = self.forward_part1(x, quant)
ctx = self.forward_part2(x1)
return ctx, ctx_t
you passed x1 (output of first part BEFORE multiplying by $q_f$
why?
- Dominant language
- Python
- Stars
- 829
- Forks
- 138
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 1
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from microsoft/DCVC
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
syfoud/Simulated_Scepter#172 ·
-
A cancelled tests run makes the coverage comment workflow fail and reports it as a red check on main Openarea: ci bug perceived difficulty: 3
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Nitjsefnie-Harness-Commons/daedalus#921 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
EleutherAI/lm-evaluation-harness#4207 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
ClickHouse/clickhouse-connect#1057 ·