Code: DirectLineJS should empty out contentUrl if it is a placeholder

Open
#265 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript, typescript
Domain
api

Research direction

Start in core/src/reducers/activities.js and inspect the TODO describing the contentUrl removal. Trace the DirectLineJS adapter path to determine where this behavior belongs; done means the placeholder contentUrl handling is performed there rather than in the reducer.

Written by the indexing model from the issue text.

Description

Feature Request

In core/src/reducers/activities.js, we have some code to empty out contentUrl if the attachment should not be downloadable. This code should be moved to DirectLineJS.

// TODO: [P2] This "contentURL" removal code should be moved to DirectLineJS adapter.

[Enhancement]

Dominant language
TypeScript
Stars
199
Forks
133
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/BotFramework-DirectLineJS

All issues in microsoft/BotFramework-DirectLineJS

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.