Invalid Assertion

Open
#165 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Active
Domain
documentation

Research direction

Start with the linked ALCops rule, the Record.ReadIsolation documentation, and the repository guidance containing the disputed assertion. Verify both syntaxes against the relevant AL behavior and determine which statement or example is incorrect. Done means the repository no longer presents an inaccurate claim and clearly explains the supported syntax.

Written by the indexing model from the issue text.

Description

With a recent update to the ALCops a new linter rule was put in place Use parenthesis for method calls instead of assignment syntax. Its specific example shows assignment syntax Record.ReadIsolation := IsolationLevel::ReadUncommitted vs. parameter syntaxRecord.ReadIsolation(IsolationLevel::ReadUncommitted). The documentation for Record.ReadIsolation shows the parameter syntax but the example shows the assignment syntax.

Actual usage shows that either syntax works but when making changes to standardize on the parameter syntax BC Quality returned this statement:

Record.ReadIsolation is a property, assigned with := (per this repo's own ReadIsolation convention and standard AL), not a callable member. The diff mechanically rewrites every X.ReadIsolation := IsolationLevel::...; to X.ReadIsolation(IsolationLevel::...);, which is not valid AL syntax for this property and will fail to compile everywhere it appears.

It just wrong.

  • It is not a property, it is a callable member that just happens to take assignment (like many object members in AL, e.g. Notification.Scope).
  • It is valid AL syntax
  • It does NOT fail to compile.

I am not sure where this came from but it sounds like an AI hallucination. Are there some rules you set for this kind of assertion?

Dominant language
AL
Stars
213
Forks
121
Avg merge
3d 2h
Merged PRs (30d)
33

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/BCQuality

All issues in microsoft/BCQuality

Similar issues

More Documentation issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.