Restore ObsoleteTag '28.0' on Activate Legacy Subcontracting action (suppress AS0072 via pragma)

Open Beginner friendly
#9,163 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
85/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Domain
build-system

Research direction

Open src/Layers/IT/BaseApp/Manufacturing/Setup/ManufacturingSetup.Page.al and compare the Activate Legacy Subcontracting action with its sibling actions and the LegacySubcontracting group. Review the pragma pattern in src/Layers/GB/BaseApp/Purchases/Vendor/VendorTempl.Table.al; done means the action uses ObsoleteTag '28.0' while AS0072 is suppressed locally.

Written by the indexing model from the issue text.

Description

Team: SCM

On the IT Manufacturing Setup page (page 99000768 "Manufacturing Setup"), the "Activate Legacy Subcontracting" action currently sets ObsoleteTag = '29.0'.

This value was bumped from '28.0' to '29.0' in #8966 solely to satisfy the AppSourceCop rule AS0072 (ObsoleteTag must match obsoleteTagVersion = 29.0). The action logically belongs to the same '28.0' obsoletion wave as the sibling "Disable Legacy Subcontracting" and "Pre Check Disable Legacy Subcontracting" actions and the parent LegacySubcontracting group, which all carry ObsoleteTag = '28.0'.

Proposed change

Restore ObsoleteTag = '28.0' on the "Activate Legacy Subcontracting" action and suppress AS0072 locally with a pragma, consistent with the existing pattern used elsewhere in the codebase (e.g. src/Layers/GB/BaseApp/Purchases/Vendor/VendorTempl.Table.al):

#pragma warning disable AS0072
                    ObsoleteTag = '28.0';
#pragma warning restore AS0072
File
  • src/Layers/IT/BaseApp/Manufacturing/Setup/ManufacturingSetup.Page.al
Dominant language
AL
Stars
683
Forks
459
Avg merge
2d 20h
Merged PRs (30d)
621

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/BCApps

All issues in microsoft/BCApps

Similar issues

More Build System issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.