[Bug]: TryGetDictionaryValueFromKey should not be a try function

Start at page 9082, "Customer Statistics FactBox," and inspect TryGetDictionaryValueFromKey and its calls in OnPageBackgroundTaskCompleted. Review launch.json with breakOnError enabled, then verify that missing dictionary keys no longer trigger the debugger while the expected values are still evaluated and assigned.

Describe the issue

In page 9082 "Customer Statistics FactBox" there is a LOCAL function:

[TryFunction]
local procedure TryGetDictionaryValueFromKey(var DictionaryToLookIn: Dictionary of [Text, Text]; KeyToSearchFor: Text; var ReturnValue: Text)
begin
ReturnValue := DictionaryToLookIn.Get(KeyToSearchFor);
end;

And only gets used in the trigger:

trigger OnPageBackgroundTaskCompleted(TaskId: Integer; Results: Dictionary of [Text, Text])
var
CalculateCustomerStats: Codeunit "Calculate Customer Stats.";
DictionaryValue: Text;
begin
if (TaskId = TaskIdCalculateCue) then begin
if Results.Count() = 0 then
exit;

        if TryGetDictionaryValueFromKey(Results, CalculateCustomerStats.GetLastPaymentDateLabel(), DictionaryValue) then
            Evaluate(LastPaymentDate, DictionaryValue);

        if TryGetDictionaryValueFromKey(Results, CalculateCustomerStats.GetTotalAmountLCYLabel(), DictionaryValue) then
            Evaluate(TotalAmountLCY, DictionaryValue);

        if TryGetDictionaryValueFromKey(Results, CalculateCustomerStats.GetOverdueBalanceLabel(), DictionaryValue) then
            Evaluate(OverdueBalance, DictionaryValue);

        if TryGetDictionaryValueFromKey(Results, CalculateCustomerStats.GetSalesLCYLabel(), DictionaryValue) then
            Evaluate(SalesLCY, DictionaryValue);

        if TryGetDictionaryValueFromKey(Results, CalculateCustomerStats.GetInvoicedPrepmtAmountLCYLabel(), DictionaryValue) then
            Evaluate(InvoicedPrepmtAmountLCY, DictionaryValue);

        if TryGetDictionaryValueFromKey(Results, CalculateCustomerStats.GetLinkedVendorNoLabel(), DictionaryValue) then
            LinkedVendorNo := CopyStr(DictionaryValue, 1, MaxStrLen(LinkedVendorNo));
        BalanceAsVendorEnabled := LinkedVendorNo <> '';
        if BalanceAsVendorEnabled then
            if TryGetDictionaryValueFromKey(Results, CalculateCustomerStats.GetBalanceAsVendorLabel(), DictionaryValue) then
                Evaluate(BalanceAsVendor, DictionaryValue);
    end;
end;

This is extremely annoying when starting a debug session and opening a page where this factbox is shown. Next to the fact this is a weird way to retrieve a value from a dictionary. I suggest using the if contains functionality. As I will describe in the expected behavior.

Expected behavior

Remove the Try function tag and make changes to procedure like this:

local procedure TryGetDictionaryValueFromKey(var DictionaryToLookIn: Dictionary of [Text, Text]; KeyToSearchFor: Text; var ReturnValue: Text): Boolean
begin
if not DictionaryToLookIn.ContainsKey(KeyToSearchFor) then
exit(false);
ReturnValue := DictionaryToLookIn.Get(KeyToSearchFor);
exit(true);
end;

Steps to reproduce

Start debug session without any breakpoints but with "breakOnError":true, in the launch.json

Additional context

No response

I will provide a fix for a bug

• I will provide a fix for a bug