Postcode Configuration Page shows an empty Address Provider when a provider is configured

Open
#11,255 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
35/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Domain
frontend

Research direction

Start with OnOpenPage on pages 9143 and 10501, "Postcode Configuration Page W1" and "Postcode Configuration Page". Reopen each page with a configured provider and verify that the Address Provider field displays the selected provider rather than an empty value; the proposed fix is already implemented on a contributor branch.

Written by the indexing model from the issue text.

Description

Team: Finance

Describe the issue
OnOpenPage of page 9143 "Postcode Configuration Page W1" (and the GB twin, page 10501 "Postcode Configuration Page") sets the display variable ServiceKeyText only in the record-missing and not-configured branches — both to Disabled. With a correctly configured provider neither branch runs, so the "Address Provider" field renders an empty value (shows as an underscore in the web client) instead of the selected provider. The stored key is already read into PrevValue; it is just never displayed.

Reproduced on BC 28.2 with a configured, working postcode provider. This was previously masked for IdealPostcodes because a provider bug (see the linked IdealPostcodes issue) kept IsConfigured() false, which forced the page into the Disabled branch.

Expected behavior
Reopening the Postcode Configuration Page shows the currently selected provider.

Proposed fix (implemented)
In both pages, replace the last statement of OnOpenPage:

// old
PrevValue := Rec.GetServiceKey();
// new
ServiceKeyText := Rec.GetServiceKey();
PrevValue := ServiceKeyText;

A PR with this change is ready on branch sergey-idealpostcodes:fix/postcode-configuration-page-show-selected-provider and will be opened once this issue is approved.

Dominant language
AL
Stars
683
Forks
459
Avg merge
2d 20h
Merged PRs (30d)
621

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/BCApps

All issues in microsoft/BCApps

Similar issues

More Web Dev issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.