[Extensibility Request][Subscription Billing] Remove internal access from SetParameter procedures on page "Extend Contract"

Open Beginner friendly
#10,629 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
76/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Domain
backend

Research direction

Search the BCApps source for page 8002 "Extend Contract" and the SetParameters and SetUsageBasedParameters declarations. Read how the existing generic connector invokes the page, then verify both procedures are externally callable and the custom usage data connector path can invoke them.

Written by the indexing model from the issue text.

Description

Approved request-for-external Team: Finance
Describe the issue

The procedures internal procedure SetParameters(NewCustomerNo: Code[20]; NewCustomerContractNo: Code[20]; NewProvisionStartDate: Date; NewExtendCustomerContract: Boolean) and 'internal procedure SetUsageBasedParameters(SupplierNo: Code[20]; NewSubscriptionEntryNo: Integer)' are both set to internal, thus the page 8002 "Extend Contract" cannot be called from anywhere else.
The page should be called from the import a custom usage data connector (like it is for the existing generic connector)

Expected behavior

Both procedures should not be internal, the page isn't and the functionality of the page only makes sense if one can call those procedures.

Steps to reproduce

not applicable

Additional context

No response

I will provide a fix for a bug
  • I will provide a fix for a bug
Dominant language
AL
Stars
683
Forks
459
Avg merge
2d 20h
Merged PRs (30d)
621

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/BCApps

All issues in microsoft/BCApps

Similar issues

More Backend & API Design issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.