Remove dependency on xbmc ppa

Open Beginner friendly
#194 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
68/100
Issue type
Documentation
Clarity
Clearly specified
Activity status
Stale
Tech stack
cpp, ubuntu
Domain
documentation

Research direction

Start by checking the PPA references in build/Phase2/install_prereqs.cmd and src/Linux/README.MD. Remove the team-xbmc PPA instructions from the documented setup, then search the repository for remaining team-xbmc references to confirm the obsolete dependency is no longer mentioned.

Written by the indexing model from the issue text.

Description

  1. The code uses nlohmann/json.hpp
  2. It is provided by nlohmann-json3-dev
  3. It was not available in the official Ubuntu 18 package repo and thus in the notes the PPA of Kodi (team-xbmc) is mentioned as dependency, e.g.
Azure-DCAP-Client (master)> grep -R team-xbmc
build/Phase2/install_prereqs.cmd
12:add-apt-repository ppa:team-xbmc/ppa -y

src/Linux/README.MD
9:* `sudo  add-apt-repository ppa:team-xbmc/ppa -y`
  1. nlohmann-json3-dev is available in the official repo for Ubuntu 20 and up, e.g. https://packages.ubuntu.com/focal/nlohmann-json3-dev

Since dcap deprecated support for Ubuntu 18, the ppa is not needed. As it is best practice not to have unneeded PPAs, I suggest removing this from the docs.

Dominant language
C++
Stars
66
Forks
44
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/Azure-DCAP-Client

All issues in microsoft/Azure-DCAP-Client

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.