micrometer-metrics/micrometer

Support for removing metrics registered by CaffeineCacheMetrics

Open

#5297 opened on Jul 10, 2024

View on GitHub
 (12 comments) (0 reactions) (0 assignees)Java (4,220 stars) (935 forks)batch import
enhancementhelp wantedinstrumentationmodule: micrometer-core

Description

Please describe the feature request. Currently we are able to add instrumentations of lets say caffeine cache based on a reference but we can't remove them.

Rationale The rationale behind this is we have a caffiene cache that is configurable from database config and hence we change the reference for the same and they are re-constructed. In this case we remove the reference to old caches and add new ones but we want to re-register the new ones but since one is already registered with the ealier name the new one is not registered and honoured, hence we should have a way to remove the old ones and be able to replace it with the new ones.

Contributor guide

Tech stack
java
Domain
performancebackend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaMicrometerCaffeine
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate how CaffeineCacheMetrics currently registers metrics in the MeterRegistry. Look for existing methods that bind Caffeine caches to meters and consider adding a counterpart to remove them. Review related issues and discussions in the comments for design preferences.