micrometer-metrics/micrometer

Test osgi with new Prometheus client

Open

#5063 opened on May 10, 2024

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Java (4,220 stars) (935 forks)batch import
help wantedtype: task

Description

See the description of https://github.com/micrometer-metrics/micrometer/pull/4846.

The OSGi test was failing when the new Prometheus client was used, so it was updated to use the -simpleclient module for now.

We should make sure we're testing with the latest Prometheus client and figure out what the issue is that's causing it to fail.

Contributor guide

Tech stack
java
Domain
testing
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
OSGi testing basicsPrometheus client library
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The OSGi test currently uses the simpleclient module as a workaround. Review the changes in PR #4846 (https://github.com/micrometer metrics/micrometer/pull/4846) to understand the failure. Set up the test environment to reproduce the issue with the new Prometheus client, focusing on classloading or dependency resolution in an OSGi container. Check the test configuration and bundle imports. Propose a fix or update the test to use the correct client version without workaround.