Bug : DownloadArtifact reading request body instead of response body

Open Beginner friendly
#375 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
76/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Tech stack
go
Domain
api, cli

Research direction

Locate the DownloadArtifact function and inspect the HTTP response handling after the request is executed, especially the import-url path. Verify that artifact content comes from the server response and reproduces the expected SUCCESS_FROM_SERVER result rather than an empty value.

Written by the indexing model from the issue text.

Description

Describe the bug

The DownloadArtifact function incorrectly reads from req.Body instead of resp.Body after executing the HTTP request.

Current implementation:

respBody, err := io.ReadAll(req.Body)

This causes the function to read the request payload rather than the server response body, which may lead to empty or invalid artifact content when using import-url functionality.

Expected behavior:

Microcks has discovered 'SUCCESS_FROM_SERVER'

Actual behavior:

Microcks has discovered ''

How to Reproduce?

No response

Microcks version or git rev

No response

Install method (docker-compose, helm chart, operator, docker-desktop extension,...)

No response

Additional information

No response

Dominant language
Go
Stars
52
Forks
67
Avg merge
1d 1h
Merged PRs (30d)
13

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microcks/microcks-cli

All issues in microcks/microcks-cli

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.