micro-analytics/micro-analytics-cli

Connection leaks in adapter tests

Open

#75 opened on Jun 29, 2017

View on GitHub
 (0 comments) (1 reaction) (0 assignees)JavaScript (738 stars) (52 forks)batch import
adapter-testshelp wanted

Description

The adapter tests does not close connection correctly resulting in tests for the redis adapter never quitting.

The problem is the at the moment is call init should not throw. Overwrites the connections with new one and then when the tests closes connection in afterEach the connection created in beforeEach is not closed.

I think it would be a good thing to require adapter.close() and handle the closing of database connections in the adapter utils.

Contributor guide

Tech stack
javascriptnodejsredis
Domain
backendtestingdatabase
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Node.js basicsTesting with JestRedis basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Examine the adapter test files, likely located in a 'tests/' or 'test/' directory. Focus on the 'beforeEach' and 'afterEach' hooks to identify where connections are not being closed. The suggestion in the issue is to implement an 'adapter.close()' method and ensure it is called in the test teardown. Check if the repository has any recent activity or maintainer responses to gauge current maintenance status.