Messages (and svcs and action goals) larger than a certain size seem to 'disappear'

Open
#143 10 comments 0 reactions 2 assignees View on GitHub

@Acuadros95 is already working on this.

Since May 24, 2022.

Assessment

This issue has not been assessed yet.

Description

bug

Describe the bug

Agents do not appear to forward messages coming in from the "ROS 2 side" that are larger than a certain size.

Increasing the verboseness of the Agent, DDS messages with len: 67776 for instance just disappear. There are no warnings or errors printed by the Agent, and the Client doesn't appear to receive anything, nor does it notify the Agent of any error.

For reference, this was also discussed in https://github.com/micro-ROS/rmw_microxrcedds/issues/258.

To Reproduce
Steps to reproduce the behaviour:

Not exactly steps, but at a high level:

  1. implement a Client capable of subscribing to a message with a variable sized payload
  2. create a rclcpp or rclpy publisher which publishes instances of this message
  3. gradually increase size of the payload from something small to 'something large'
  4. notice how at a certain point, the Client no longer receives any messages

Alternatively: create a server service and client, or an action server and client, which exchange the described message (as one of the fields fi).

Service invocations and action goal submissions will silently start to fail for messages "too large".

Expected behaviour
Ideally: messages of all sizes (even large ones) get forwarded successfully.

Realistically (as unlimited memory doesn't exist): the Agent prints a warning or error, clearly showing it's impossible to forward a message.

If possible: in case of svcs and actions: notify the client the invocation failed -- due to RMW-level failures (so not the invocation itself, but the request didn't even arrive at the server).

System information (please complete the following information):

  • OS: observed under Ubuntu 20.04, but same happens on other OS
  • ROS 2 Foxy, Galactic and Rolling
  • Version: using the "most recent" Docker image (microros/micro-ros-agent / 5e93b1fa5608)
Dominant language
C++
Stars
201
Forks
111
Avg merge
1d 6h
Merged PRs (30d)
10

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from micro-ROS/micro-ROS-Agent

All issues in micro-ROS/micro-ROS-Agent

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.