mholt/PapaParse

preview + step never completes

Open

#618 opened on Jan 21, 2019

View on GitHub
 (3 comments) (3 reactions) (0 assignees)JavaScript (1,157 forks)batch import
help wanted

Repository metrics

Stars
 (11,877 stars)
PR merge metrics
 (Avg merge 18h) (1 merged PR in 30d)

Description

The discussion (in #352) and the docs indicate that the meta.truncated value should become true when the last row to preview is parsed. But it doesn't it remains false and complete is never called. This means short of keeping your own counter there is no way to know that preview has completed.

To repro:

  • Go to the demo.
  • Select local file.
  • check Stream option.
  • Set preview to any positive non-zero value
  • Click parse
  • Nothing ever shows up in the console

Contributor guide

Research direction
Trace the code path for preview mode and step callback to understand why meta.truncated is not being set.
Tech stack
javascript
Domain
data
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65