mholt/PapaParse

Quote only strings and not numbers

Open

#532 opened on Jul 5, 2018

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (1,186 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (13,552 stars)
PR merge metrics
 (PR metrics pending)

Description

I'm parsing the following file (quoted strings, non-quotes numbers):

name,age,city
"Chirstian",30,"Hamburg"

The option dynamicTyping detects name and city as strings and the age as number. If I unparse, I have two options.

Option 1) set quoteChar: '"', which results in:
name,age,city
"Chirstian","30","Hamburg"
Option 1) Skip the option `quoteChar, which results in:
name,age,city
Chirstian,30,Hamburg

I recommend an option onlyQuoteStrings, which applies the quoteChar: '"' only to strings, but not to numbers, similar to libre office save as CSV dialogue (option quote all text cells):

bildschirmfoto vom 2018-07-05 23 59 54

Contributor guide

Research direction
Implement a new option `onlyQuoteStrings` in the unparse function to conditionally quote only string fields, leaving numeric fields unquoted.
Tech stack
javascript
Domain
api
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70