mholt/PapaParse

Wrong row reported for `InvalidQuotes`

Open

#432 opened on Nov 8, 2017

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (11,877 stars) (1,157 forks)batch import
help wanted

Description

With version 4.3.6, in some cases, the wrong row is reported. A test case:

Papa.parse(
  `a,b,c
   1,2,3,
   4,"5"5",6
   7,8,9`, 
{header:true}).errors

Results in

[
  {"type":"Quotes","code":"InvalidQuotes","message":"Trailing quote on quoted field is malformed","row":2,"index":16},
  {"type":"FieldMismatch","code":"TooManyFields","message":"Too many fields: expected 3 fields but parsed 4","row":0}
]

A field mismatch occurs on row 0 and then one expects the invalid quotes to be reported on row 1 but it's on row 2 instead. This doesn't happen with version 4.3.5 which doesn't report the invalid quotes at all.

Here's the fiddle https://jsfiddle.net/011ev54k/

Contributor guide

Tech stack
javascript
Domain
data
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptCSV parsingPapaParse source code structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue reports that the wrong row is reported for InvalidQuotes errors. The test case provided should be used to reproduce the bug. Focus on the quote parsing logic in 'papaparse.js', specifically the part that detects invalid quotes and assigns row numbers. Compare with version 4.3.5 to see what changed (the error was not reported before). Look for any commit or PR that introduced the InvalidQuotes error and trace the row indexing logic. The fix likely involves correcting the row counter when a quote anomaly is encountered during parsing.