check-python-versions --add ... drops the Python :: 3 :: Only classifier

Open
#32 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
48/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
python
Domain
cli, tooling

Research direction

Reproduce the issue with check-python-versions --add 3.10 --diff at commit 61023f599d5bbdb2b5b7ff2e9404f0e40ca170f7, then inspect the logic that updates classifiers in setup.py. Done means the command adds the Python 3.10 classifier while preserving Python :: 3 :: Only and other existing classifiers.

Written by the indexing model from the issue text.

Description

bug

Steps to reproduce:

  1. git clone https://github.com/mgedmin/check-manifest
  2. git checkout 61023f599d5bbdb2b5b7ff2e9404f0e40ca170f7
  3. check-python-versions --add 3.10 --diff

Expected:

  • adds 3.10, doesn't touch anything else

Actual:

--- ./setup.py	(original)
+++ ./setup.py	(updated)
@@ -44,11 +44,11 @@
         'Operating System :: OS Independent',
         'Programming Language :: Python',
         'Programming Language :: Python :: 3',
-        'Programming Language :: Python :: 3 :: Only',
         'Programming Language :: Python :: 3.6',
         'Programming Language :: Python :: 3.7',
         'Programming Language :: Python :: 3.8',
         'Programming Language :: Python :: 3.9',
+        'Programming Language :: Python :: 3.10',
         'Programming Language :: Python :: Implementation :: CPython',
         'Programming Language :: Python :: Implementation :: PyPy',
     ],
Dominant language
Python
Stars
24
Forks
14
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from mgedmin/check-python-versions

All issues in mgedmin/check-python-versions

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.