Opposite of increment-decrement (for non-loop-counter usage) · mgechev/revive#910

(1 comment) (0 reactions) (0 assignees)Go (316 forks)github user discovery

good first issuerule proposal

Repository metrics

Is your feature request related to a problem? Please describe.

The increment-decrement rule is quite opinionated, as many rules are. However, its suggestion is problematic in the sense that e.g.

it's not that common of a practice in my experience to use ++/-- in contexts other than loop counters in Go code, e.g. stdlib
many programming languages don't even have those operators (for example Python, Rust, Swift, Zig)

Describe the solution you'd like

increment-decrement can be disabled like all others, no problem with that, and that does not require a solution.

But for the above reasons, a rule that would do the opposite of increment-decrement for anything but loop counters would be nice to have.

Describe alternatives you've considered

Just disabling increment-decrement, but that won't help with adoption of the += 1 style.

Additional context

N/A.

Research direction: Study the existing increment decrement rule implementation in revive (likely in rules/increment decrement.go) to understand the pattern for adding a new rule. Then design a new rule that flags i += 1 for non loop counter variables and suggests i++ instead (or the opposite).
Tech stack: go
Domain: backendtooling
Issue type: Feature
Difficulty: 3
Estimated time: 3-5 days
Activity status: Active
Clarity: Clear
Prerequisites: Go
Newbie friendliness: 65