mgechev/revive

Allow to ignoring "unhandled errors" by their type and method

Open

#671 opened on Apr 7, 2022

View on GitHub
 (6 comments) (1 reaction) (0 assignees)Go (316 forks)github user discovery
enhancementgood first issue

Repository metrics

Stars
 (5,517 stars)
PR merge metrics
 (PR metrics pending)

Description

Is your feature request related to a problem? Please describe.

When one is using the method "WriteString" of the type "strings::Builder" and does not handle the error it is flagged because all errors must be handled. However, This method never returns an error. Hence, it makes sense to ignore it (even by default).

The problem with revive is, that it does not allow to ignore methods with their type, since one can only ignore them with their variable name. So instead of "strings.Builder.WriteString" (or another annoation) to ignore it, i need to write "b.WriteString" (in our code this is one instance) which however, would include implementations that do return an error.

Describe the solution you'd like

Allow to define "strings.Builder.WriteString" (or "strings::Builder.WriteString") to allow to ignore the method "WriteString" of the type "Builder" in the package "strings".

Contributor guide