metricsgraphics/metrics-graphics

Respect custom elements on domain computation

Open

#899 opened on Aug 19, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (7,262 stars) (524 forks)batch import
good first issue

Description

I cannot get my large confidence band to fit in the graph. It is cut by the frame itself. Image attached. image

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
basic JavaScriptfamiliarity with D3 or visualization libraries
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue concerns confidence bands being cut off by the graph frame. Investigate how the domain (y axis range) is computed for custom elements like confidence bands. Likely located in source files handling scales or domain calculations, e.g., src/js/processors/ or src/js/scales/. Check if the domain computation ignores the extent of custom elements. A fix might involve extending the domain to include all data elements, including custom bands.