metricsgraphics/metrics-graphics

When max_y or min_y is set, the chart line sometimes curves in such a way that peaks are invisible

Open

#823 opened on Feb 27, 2018

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (7,262 stars) (524 forks)batch import
bughelp wanted

Description

Steps to reproduce

Download and open this HTML document

Actual result

Screenshot

Expected result

The chart should look something like this (achieved by removing max_y):

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptSVG path rendering
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate the chart line rendering logic in the repository, particularly how max y and min y affect the y scale and clipping. The provided HTML reproduction demonstrates the issue; check the source code for line drawing (likely in a file like 'src/js/charts/line.js'). Look for any existing comments or issues mentioning similar problems. No linked PRs or assignees, so the issue is open for contribution.