metosin/reitit

[Feature] Add handlers registry

Open

#695 opened on Aug 26, 2024

View on GitHub
 (2 comments) (1 reaction) (0 assignees)Clojure (1,569 stars) (261 forks)batch import
enhancementhelp wanted

Description

Just like middleware registry, but with a few open questions:

  • Should it be an opt of ring.core/router?
  • How should resolution be performed? Just postwalk and look for :handler?
    • Does that risk mangling input data?
    • Same for metadata (meta merge)
    • Can be done after merge but before compilation
  • Belong in core or ring?

Contributor guide

Tech stack
None
Domain
backend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Clojurereitit routingring middleware
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Review the issue at https://github.com/metosin/reitit/issues/695 and the existing middleware registry implementation. Investigate the open questions: whether handlers registry should be an opt of ring.core/router, how resolution should work (postwalk for :handler), and potential risks of mangling input data or meta merge. Check if there are prior discussions or related PRs. The issue has 2 comments and 1 reaction, indicating initial interest but no concrete proposal. Engage with maintainers to clarify scope and acceptance criteria before proceeding.