metosin/reitit

Support Plumatic Schema for multipart file uploads

Open

#594 opened on Mar 15, 2023

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Clojure (1,569 stars) (261 forks)batch import
enhancementhelp wanted

Description

Currently reitit.http.interceptors.multipart only has Clojure spec schemas for temp-file-part and bytes-part. Could also supply schema & malli versions.

See reitit.openapi-test/multipart-test for inspiration: https://github.com/metosin/reitit/pull/593/files#diff-c18bf86982356e8898ead05214985b1ffa8f85f77f47094ac56cf82cb5eb95b7R434

Related to #591

Contributor guide

Tech stack
None
Domain
backend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Clojure basicsPlumatic Schema knowledgeReitit multipart internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Examine the existing `temp file part` and `bytes part` schemas in `reitit.http.interceptors.multipart` (likely in src directory). Refer to the openapi test/multipart test in the linked PR #593 for inspiration on how malli versions are implemented. Also review issue #591 for context on openapi multipart schema. The goal is to implement a similar validation schema using Plumatic Schema (prone to be in a separate namespace or alongside existing ones).