metosin/malli

Metadata-defined function schemas do not get reinstrumented by malli.dev

Open

#861 opened on Mar 5, 2023

View on GitHub
 (2 comments) (1 reaction) (0 assignees)Clojure (1,724 stars) (237 forks)batch import
bughelp wanted

Description

Hello :wave:

I have noticed that functions schemas defined with metadata do not get reinstrumented by malli.dev on namespace reload. Any change to the file and namespace reload causes instrumentation to stop working.

This issue does not happen when a function is instrumented with malli.core/=>.

See the video showing this happening on the newest [metosin/malli "0.10.2"]:

https://user-images.githubusercontent.com/4920654/222991613-2e22a9ef-faf9-4e94-91d6-0c7aed07a572.mov

I'm not sure if it's just a bug or a known limitation but it takes away the dev utility of metadata schemas.

Let me know if I could help you with fixing it and big thank you for the library and those dev instrumentation features!

Contributor guide

Tech stack
None
Domain
developer experiencetooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Clojure basicsunderstanding of malli instrumentation
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
15
Research direction
Investigate the difference in reinstrumentation behavior between metadata defined function schemas and those defined with malli.core/=>. Focus on the malli.dev namespace and the function schemas.md documentation. Check the source code for how metadata based schemas are registered and why they are not reinstrumented on namespace reload. Look at related issues or PRs for context.
Metadata-defined function schemas do not get reinstrumented by malli.dev · metosin/malli#861 | Good First Issue