Fallback nicely if new Layout({})

Open
#31 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript
Domain
frontend

Research direction

Start by inspecting the Layout constructor and the utility containing utils.isElement, then review the Packery tests that exposed the regression. The change is done when new Layout({}) handles a non-element argument without failing and the relevant Packery tests pass.

Written by the indexing model from the issue text.

Description

Should bail nicely if user enters non-element argument for new Layout(). Fixes regression with Packery tests.

should get utils.isElement( queryElement )

Dominant language
JavaScript
Stars
166
Forks
63
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from metafizzy/outlayer

All issues in metafizzy/outlayer

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.