mesonbuild/meson

`ninja clean` does not remove meson-dist directory

Open

#3,789 opened on Jun 25, 2018

View on GitHub
 (0 comments) (3 reactions) (0 assignees)Python (4,978 stars) (1,465 forks)batch import
distgood first issue

Description

Steps to reproduce:

  1. ninja dist
  2. ninja clean

Expected results: All generated files should be removed.

Actual results:

[4/4] Cleaning.
FAILED: meson-clean 
ninja -t clean
ninja: error: remove(meson-dist): Directory not empty
Cleaning... 0 files.

Contributor guide

Tech stack
python
Domain
build system
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with Meson build systemPython 3
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue is that `ninja clean` fails to remove the meson dist directory because it is not empty. The likely fix is to add a step in the clean target to remove the meson dist directory or its contents. The relevant source files are likely in the `mesonbuild` Python package, specifically the clean related code. Check the `mesonbuild/mcompile.py` or similar files for how cleaning is implemented. The maintainers may need to decide whether to delete the entire directory or just its contents.