mesonbuild/meson

coverage targets ?

Open

#2,953 opened on Jan 19, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (4,978 stars) (1,465 forks)batch import
buggood first issuehelp wanted

Description

I'm trying to close the issue #2805, and i'm discovering something strange:

  • ninja coverage -> call meson --internal
  • ninja coverage-html -> call lcov
  • ninja meson-coverage -> call meson --internal (coverage alias)
  • ninja meson-coverage-html -> call lcov (coverage-html alias)

The calls to lcov are currently implemented twice, in scripts/coverage.py and backends/ninjabackend.py. And the implementations are not the same…

That should be cleaned. One solution is to write only ninja targets:

  • coverage-html : call lcov, genhtml (just like in scripts/coverage.py)
  • coverage-txt : call gcovr
  • coverage-xml : call gcovr
  • coverage : depends on the 3 other targets.

EDIT : I'm seeing that the move went from ninja targets to meson internal script. Is there a reason ? Anyway, one would suppose meson-* targets will call meson --internal, and that's not the case.

Contributor guide

Tech stack
python
Domain
build system
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
understanding of Meson build systemfamiliarity with Pythonknowledge of ninja build tool
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue identifies duplicate implementations of lcov coverage commands in scripts/coverage.py and backends/ninjabackend.py. Start by examining both files to understand the current differences. Then propose a unified solution, such as creating ninja targets for coverage html, coverage txt, coverage xml, and a coverage alias that depends on them. Investigate why the move from ninja targets to meson internal scripts was made by checking related commits or issues. The solution should ensure consistency and possibly remove duplication.