mesonbuild/meson

Warn when build files use `object.path()` in places where `object` should be used

Open

#2,742 opened on Dec 6, 2017

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Python (4,978 stars) (1,465 forks)batch import
enhancementhelp wantedparser/interpreter

Description

If script.sh exists, has a shebang but is not executable then the following two lines will case an error when trying to invoke the run target.

myscript = find_program('script.sh')
run_target('myscript', command : myscript.path())

I could not track down the exact cause of the problem. When meson searches for the program it will recognize that the file is not executable and look for the shebang. (It might be a good idea to warn about this on *nix platforms.) It then identifies the interpreter and creates an external program with the interpreter and the script file.

When trying to invoke the program in run_script_command the interpreter is lost and we fail to execute the non-executable script.

Contributor guide

Tech stack
python
Domain
build system
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Basic knowledge of Meson build systemPython debugging
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate how mesonbuild's find program and run target handle non executable scripts with shebangs. Look at the code in mesonbuild/interpreter.py or mesonbuild/program.py to trace the program detection logic. Consider adding a warning when a build file uses object.path() where object is a non executable script that was wrapped with an interpreter. Check linked comments for additional context.