mesonbuild/meson

Warning color is unreadable on white background

Open

#2,370 opened on Sep 24, 2017

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Python (4,978 stars) (1,465 forks)batch import
bughelp wanted

Description

When printing warnings, the word 'WARNING' is printed in bright yellow. This is unreadable on a white background. I suggest orange would be a better color to use.

meson-color.txt

Contributor guide

Tech stack
python
Domain
cli
Issue type
accessibility
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
95
Research direction
The warning message 'WARNING' is likely printed with a yellow color in the Meson build system's output. The repository uses ANSI escape codes for coloring. Look for references to 'WARNING' in the codebase, possibly in a logging or color module. Change the color code from yellow (e.g., '33' or '93') to orange (e.g., '38;5;214' or '33' with different intensity). The attached 'meson color.txt' file may provide context on current color mapping. There are 3 comments on the issue that may contain additional discussion.
Warning color is unreadable on white background · mesonbuild/meson#2370 | Good First Issue