mesonbuild/meson

vcs_tag() error output should be silenced if fallback is specified

Open

#2240 opened on Aug 23, 2017

View on GitHub
 (12 comments) (0 reactions) (0 assignees)Python (4,978 stars) (1,465 forks)batch import
bughelp wanted

Description

meson's vcs_tag function is very useful but the fact that it always generates error output if no annotated tag matching the current git revision is found is... unnecessary.

We use actual git revisions as our version numbers for intermediate releases, so we provide the output of git rev-parse HEAD as the value of the fallback parameter to vcs_tag. That works great, but each time meson complains about no annotated tags:

ninja -C debug
ninja: Entering directory `debug'
[1/4] Generating GitVersion.cpp with a custom command.
fatal: No annotated tags can describe 'e5c806c6a0fc0380637b955b018485ccd1214ddd'.
However, there were unannotated tags: try --tags.

If a fallback is provided, I think that output should be silenced.

Contributor guide

Tech stack
pythonshell
Domain
build systemtooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic understanding of Meson build systemPython scripting
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Locate the implementation of the vcs tag function in the Meson source code (likely in mesonbuild/interpreter.py or a similar module). Identify where the git command is executed and its output captured. Determine the condition under which a fallback is provided. Modify the code to suppress stderr output from the git command when a fallback is specified. Refer to the existing error handling patterns in the codebase, such as quiet flags on other commands. No linked PRs or recent comments provide a solution, so the task is to implement the feature as described.