mesonbuild/meson

configure_file(): allow more than one substitution per string

Closed

#1,864 opened on May 29, 2017

View on GitHubContributor guide
 (3 comments) (0 reactions) (0 assignees)Python (1,465 forks)batch import
enhancementgeneratorshelp wanted

Repository metrics

Stars
 (4,978 stars)
PR merge metrics
 (Avg merge 139d 13h) (51 merged PRs in 30d)

Description

this currently doesn't work:

configure_file(
    ...
    command : [ 'sh', '-c', '... "@INPUT@" > "@OUTPUT@"' ],
)

The problem is that mesonlib.substitute_values() does the substition using if..elif instead of if..if.

Contributor guide

Research direction
Locate `substitute values` in `mesonlib` and change `elif` to `if` to allow multiple substitutions.
Tech stack
python
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80