mesonbuild/meson

configure_file(): allow more than one substitution per string

Open

#1,864 opened on May 29, 2017

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Python (4,978 stars) (1,465 forks)batch import
enhancementgeneratorshelp wanted

Description

this currently doesn't work:

configure_file(
    ...
    command : [ 'sh', '-c', '... "@INPUT@" > "@OUTPUT@"' ],
)

The problem is that mesonlib.substitute_values() does the substition using if..elif instead of if..if.

Contributor guide

Tech stack
python
Domain
build systemtooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic PythonKnowledge of Meson build system
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Locate the `mesonlib.substitute values()` function in the Meson source code. The issue states that it uses `if..elif` for substitution, which prevents multiple substitutions per string. Change the logic to use `if..if` (i.e., independent if statements) to allow each placeholder to be replaced. Verify that the change works for the example command with multiple @INPUT@ and @OUTPUT@. No test changes are explicitly required, but running existing tests is advised.
configure_file(): allow more than one substitution per string · mesonbuild/meson#1864 | Good First Issue