mesonbuild/meson

Substitute absolute path to files() when used in string formatting

Open

#1,592 opened on Apr 9, 2017

View on GitHub
 (11 comments) (0 reactions) (0 assignees)Python (4,978 stars) (1,465 forks)batch import
enhancementhelp wanted

Description

From https://github.com/systemd/systemd/pull/5704#issuecomment-292796493:

But I have a trouble with makes files() work in more complicated cases: I need to a path to libudev.sym to specify it as a substring in -Wl,--version-script= option. I tried '-Wl,--version-script=' + libudev_sym '-Wl,--version-script=@0@'.format(libudev_sym)

In either of those two cases, we should substitute the absolute path to the files() object. I thought about relative paths, but there are too many corner-cases.

Contributor guide

Tech stack
python
Domain
build system
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Meson build system basicsString formatting in build files
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Review the linked comment in PR #5704 for context. Understand how files() objects are handled in string formatting in Meson's codebase. Look at relevant source files in the Meson repository, such as those handling string operations or build targets. The issue expects that when a files() object is used in string concatenation or format, its absolute path should be substituted.