mesonbuild/meson

Cross file whitespace parsing error

Open

#1497 opened on Mar 23, 2017

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Python (4,978 stars) (1,465 forks)batch import
bughelp wantedmachine filesparser/interpreter

Description

A parsing error is thrown if a closing bracket in a cross file appears at the beginning of the line.

For example, this works:

c_args = [
	'-DFOO'
	]

...but this doesn't:

c_args = [
	'-DFOO'
]

Contributor guide

Tech stack
python
Domain
build system
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Python programmingMeson build system basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the parsing logic in the Meson source code, likely in the mesonbuild/interpreter.py or parser files. The bug occurs when a closing bracket is at the beginning of a line, so examine how the parser handles whitespace and indentations. Look at existing tests for array parsing to understand expected behavior and identify where the fix should be applied.