mesonbuild/meson

Cross file whitespace parsing error

Closed

#1,497 opened on Mar 23, 2017

View on GitHubContributor guide
 (4 comments) (0 reactions) (0 assignees)Python (1,465 forks)batch import
bughelp wantedmachine filesparser/interpreter

Repository metrics

Stars
 (4,978 stars)
PR merge metrics
 (Avg merge 139d 13h) (51 merged PRs in 30d)

Description

A parsing error is thrown if a closing bracket in a cross file appears at the beginning of the line.

For example, this works:

c_args = [
	'-DFOO'
	]

...but this doesn't:

c_args = [
	'-DFOO'
]

Contributor guide

Research direction
Locate the parser code handling cross file bracket parsing. Investigate why a closing bracket at the start of a line causes an error, while indented ones do not. Check for whitespace handling logic.
Tech stack
python
Domain
build system
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70