[mesheryctl] UX: Need more informative inactive token message · meshery/meshery#4604

2021-11-11T20:36:21.000Z

_See [mesheryctl Command Tracker](https://bit.ly/3dqXy1q) for current status of commands._ #### Current Behavior Users of `mesheryctl perf profile`, who don't have an active token receive the following message: ``` ➜ ~ mesheryctl perf profile Error: failed to make a request.Get "/": stopped after 10 redirects. See https://docs.meshery.io/reference/mesheryctl/perf/profile for usage details ``` This behavior is true of a number of other commands. Each of the `app`, `pattern`, `mesh`, perf`.... should all apply the same logic and UX to the user - https://github.com/meshery/meshery/blob/2bf19d36cfd924c9c2e07fbb8686c975689309c5/mesheryctl/internal/cli/root/system/check.go#L489 #### Desired Behavior Users should be informed of their inactive token and informed to run `mesheryctl system login`. #### Acceptance Tests - [ ] 1. All `perf` commands apply this same check and UX. - [ ] 2. All `mesh` commands apply this same check and UX. - [ ] 3. All `app` commands apply this same check and UX. - [ ] 4. All `pattern` commands apply this same check and UX. --- #### Contributor Resources - ⌨️ [mesheryctl Contributing Guide](https://github.com/meshery/meshery/blob/master/mesheryctl/README.md) - [Beginner's guide to contributing to Meshery and mesheryctl](https://youtu.be/hh_kFLZx3G4) - [mesheryctl Command Tracker](https://docs.google.com/spreadsheets/d/1q63sIGAuCnIeDs8PeM-0BAkNj8BBgPUXhLbe1Y-318o/edit#gid=0) - [Meshery CLI Commands and Documentation](https://docs.google.com/document/d/1xRlFpElRmybJ3WacgPKXgCSiQ2poJl3iCCV1dAalf0k/edit#heading=h.5fucij4hc5wt) - 🙋🏾🙋🏼 Questions: [Discussion Forum](https://discuss.meshery.io) and [Community Slack](http://slack.meshery.io)

(22 comments) (0 reactions) (0 assignees)HTML (10,013 stars) (3,101 forks)batch import

area/uxcomponent/mesheryctlhelp wantedissue/remindissue/willfixkind/enhancementlanguage/go

Description

See mesheryctl Command Tracker for current status of commands.

Current Behavior

Users of mesheryctl perf profile, who don't have an active token receive the following message:

➜  ~ mesheryctl perf profile
Error: failed to make a request.Get "/": stopped after 10 redirects.
See https://docs.meshery.io/reference/mesheryctl/perf/profile for usage details

This behavior is true of a number of other commands. Each of the app, pattern, mesh, perf`.... should all apply the same logic and UX to the user - https://github.com/meshery/meshery/blob/2bf19d36cfd924c9c2e07fbb8686c975689309c5/mesheryctl/internal/cli/root/system/check.go#L489

Desired Behavior

Users should be informed of their inactive token and informed to run mesheryctl system login.

Acceptance Tests

1. All perf commands apply this same check and UX.
2. All mesh commands apply this same check and UX.
3. All app commands apply this same check and UX.
4. All pattern commands apply this same check and UX.

Contributor Resources

⌨️ mesheryctl Contributing Guide
Beginner's guide to contributing to Meshery and mesheryctl
mesheryctl Command Tracker
Meshery CLI Commands and Documentation
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

Contributor guide

Tech stack: go
Domain: cli
Issue type: feature
Difficulty: 3
Estimated time: half day
Activity status: stale
Clarity: clear
Prerequisites: Go programming basicsmesheryctl command structureunderstanding of token authentication
Newbie friendliness: 75
Research direction: Examine the existing token check in `mesheryctl/internal/cli/root/system/check.go` at line 489. Then apply a similar check and informative message to all `perf`, `mesh`, `app`, and `pattern` command files, ensuring they prompt the user to run `mesheryctl system login` when the token is inactive. Follow the pattern in the linked file and verify the changes via the acceptance criteria.