meliorence/react-native-snap-carousel

Swipes do not register in top half of portrait-oriented Carousel Card ('stack', and 'tinder')

Open

#262 opened on Feb 8, 2018

View on GitHub
 (19 comments) (10 reactions) (0 assignees)JavaScript (10,045 stars) (2,223 forks)batch import
bughelp wanted

Description

@bd-arc,

Didn't follow the Template this time around due to time constraints, but I want to put this potential issue on your radar. It's a really weird one..

To reproduce:

  • I set up a Carousel with tall (portrait-oriented) cards.
  • I found that once the card exceeded a rectangular shape, the hitbox for swipes diminished.
  • Did not do much else by way of customization. Occurs with layouts 'stack', and 'tinder'

Works:

Seeing Issue:

Thanks for taking a look.

Reproduced on iOS device / simulator. Tested in Dev mode.

Contributor guide

Tech stack
javascriptreact
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
React Native basicsgesture handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
The issue is a bug where swipes do not register in the top half of portrait oriented carousel cards for 'stack' and 'tinder' layouts. To reproduce, set up a carousel with tall cards and attempt to swipe; the hitbox appears diminished. Investigation should focus on the gesture handling code in the Carousel component, particularly the onPanResponder or onLayout methods that determine touch area. Check if the layout calculations for portrait cards have any clipping or offset issues. Also review comments on the issue for any suggested fixes or files involved, such as the CardStack or Tinder layout components.