meilisearch/MeiliSearch

Make sure payloads are effectively deleted on error

Open

#6048 opened on Dec 11, 2025

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Rust (20,887 stars) (733 forks)batch import
Internal workaffects costsbuggood first issue

Description

We found out that some payloads are not removed from the disk when an error occurs before we are able to put them in the FileStore. I would suggest we should create a temporary temporary file and extract it at the last moment.

Originally posted by @Kerollmops in https://github.com/meilisearch/meilisearch/pull/6000#discussion_r2602149151

Contributor guide

Tech stack
rust
Domain
backenddatabase
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Rustfile I/O
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
The issue references a discussion in PR #6000 where a suggestion was made to create a temporary temporary file and extract it at the last moment to ensure payloads are deleted on error. Investigate the current file storage implementation, particularly the FileStore and how files are managed. Look into creating an intermediate temp file that is only moved to the final location after successful extraction. Ensure that errors during the move or extraction are handled to avoid leftover files. The existing code can be found in the 'file store' module.