meilisearch/MeiliSearch

`latest` tag update: do it only if the GitHub release is considered as the latest one

Open

#3,177 opened on Dec 1, 2022

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Rust (20,887 stars) (733 forks)batch import
bugcontribution acceptedgithub actionshelp wantedmaintenanceOLD

Description

Currently our current CI (to move the latest tag to the appropriate commit) will push the latest tag to the latest release in term of times and not in term of version.

For example:

  • we release v1.10.0 -> latest tag will correspond to the v1.10.0 tag
  • then, later, we release v1.1.12 -> latest tag will now correspond to the v1.1.12 tag despite this is not the latest release, v1.10.0 is!

We need to run the CI only if the release is considered as the latest one by GitHub.

The latest release is defined this way on GitHub when creating a new GitHub release.

Contributor guide

Tech stack
rustgithub actions
Domain
ci cdrelease
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
GitHub Actionsversion comparison
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the current CI workflow at `.github/workflows/latest git tag.yml` and understand how the `latest` tag is currently pushed. The issue requires modifying the workflow to only run when the GitHub release is marked as 'latest' by GitHub. Look into GitHub's API to determine the latest release (e.g., using `octokit` or a similar client) and ensure the tag is updated only for that release. See previous comments for any additional context.