meilisearch/MeiliSearch

Add tests for the snapshots

Open

#2,992 opened on Oct 27, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Rust (20,887 stars) (733 forks)batch import
help wantedmaintenanceOLD

Description

There currently are not enough tests for the snapshot feature. We should make sure that they work correctly when:

  • We can create a snapshot in the right folder with the whole set of files (tasks files that contain documents).
  • We make sure that the CLI options about snapshots work correctly.

Contributor guide

Tech stack
rust
Domain
backenddatabase
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Rust programmingTesting with Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Examine the snapshot feature implementation in index scheduler/src/batch.rs (lines 556-645). Understand how snapshots are created and what files are involved. Review existing tests in the repository to follow the testing patterns. The issue mentions CLI options for snapshots, so also check the CLI argument handling code to verify those options work correctly. Focus on writing tests that create snapshots and verify the file structure and content.
Add tests for the snapshots · meilisearch/MeiliSearch#2992 | Good First Issue