meilisearch/MeiliSearch

Enable LTO again

Open

#2,718 opened on Aug 29, 2022

View on GitHub
 (7 comments) (1 reaction) (0 assignees)Rust (20,887 stars) (733 forks)batch import
enhancementhelp wantedperformancetech discussion

Description

We first enabled LTO in this PR https://github.com/meilisearch/meilisearch/pull/2690 to improve the performance of the search engine.

Then, we had to disable LTO in this PR https://github.com/meilisearch/meilisearch/pull/2717 because we were not able to compile the aarch64 binary anymore. See: https://github.com/meilisearch/meilisearch/actions/runs/2948932141

We would introduce LTO again and prevent using it when compiling the aarch64 binary. Some beginning of solution here

If anyone has a better solution, we would happy to read you!

Contributor guide

Tech stack
rust
Domain
build systemperformance
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Rust programmingCargo build systemcross compilation for ARMunderstanding of LTO
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Review the previous PRs #2690 and #2717 to understand the initial LTO enablement and the aarch64 compilation failure. Examine the suggested solution in the comments of PR #2717 (issue #2718). Check the GitHub Actions logs referenced in the issue to see the exact error. Propose a conditional LTO configuration in Cargo.toml that enables LTO for all targets except aarch64, using Rust's cfg attribute or platform specific features.
Enable LTO again · meilisearch/MeiliSearch#2718 | Good First Issue