Do not use iframe for whole button

Open
#156 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript
Domain
frontend

Research direction

No file or test is named. Start by locating the button rendering entry point and its iframe usage; confirm how the native document currently builds the button. Done means the button uses an img inside an anchor on the native document, while the iframe is retained only for the count.

Written by the indexing model from the issue text.

Description

Instead, use img with a inside on native document. iframes should be used only for count.

Dominant language
JavaScript
Stars
2.9k
Forks
263
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from mdo/github-buttons

All issues in mdo/github-buttons

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.