mblode/vscode-twig-language

FR: Add color to filters

Open

#54 opened on Jan 7, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (6 forks)github user discovery
buggood first issue

Repository metrics

Stars
 (46 stars)
PR merge metrics
 (PR metrics pending)

Description

The color change for a filter works as expected inside an output tag: Screen Shot 2021-01-07 at 11 09 36 AM

...but not inside if statements: Screen Shot 2021-01-07 at 10 56 12 AM

Contributor guide

Research direction
Investigate the TextMate grammar file for Twig syntax highlighting in the extension, specifically how filters are tokenized inside 'if' statements vs 'output' tags. Add a rule to colorize filters in 'if' blocks.
Tech stack
javascript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitVS Code extension development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70