max-mapper/menubar

Destroy Menubar

Open

#281 opened on Apr 27, 2020

View on GitHub
 (1 comment) (2 reactions) (0 assignees)TypeScript (365 forks)github user discovery
good first issue

Repository metrics

Stars
 (6,778 stars)
PR merge metrics
 (PR metrics pending)

Description

Description

There is no API to destroy a menubar instance. I'm implementing a feature in my application which will allow the end-users to run their Electron app in a tray or a window, but there is no mechanism to tear-down a menubar.

Steps to Reproduce the Problem

  1. Create a menubar
  2. Destroy Window Reference
  3. Error: Object has been destroyed: at Menubar.<anonymous> (my-app/node_modules/menubar/lib/Menubar.js:311:72)

Expected Behaviour

I'd like for the menubar instance to have a teardown function

Actual Behaviour

There is no API to support this

Specifications

  • Menubar version: 6.0.8
  • Platform: Mac
  • Electron version: 7.1.9

Other information

Contributor guide

Research direction
Understand the Menubar class lifecycle and implement a destroy method that properly disposes of the BrowserWindow and Tray, removes event listeners, and resets internal state.
Tech stack
typescriptnodejs
Domain
desktop
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ElectronTypeScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60