max-mapper/menubar

The default value of app.allowRendererProcessReuse is deprecated, it is currently "false".

Open

#273 opened on Mar 14, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (365 forks)github user discovery
annoyancegood first issue

Repository metrics

Stars
 (6,778 stars)
PR merge metrics
 (PR metrics pending)

Description

Description

Warning for deprecation:

(electron) The default value of app.allowRendererProcessReuse is deprecated, it is currently "false".  It will change to be "true" in Electron 9.  For more information please check https://github.com/electron/electron/issues/18397

Steps to Reproduce the Problem

  1. cd examples/hello-world

Expected Behaviour

No warning.

Actual Behaviour

Above warning.

Specifications

  • Menubar version: 8.0.0
  • Platform: all
  • Electron version: (Run electron -v or node_modules/.bin/electron -v to get it) 8

Other information

Contributor guide

Research direction
Set app.allowRendererProcessReuse to true in the main process before app.whenReady() to suppress the deprecation warning.
Tech stack
typescriptelectron
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90